fix(policy): use engine default verdict for QUIC#29
Merged
nnemirovsky merged 22 commits intomainfrom Apr 13, 2026
Merged
Conversation
… deny EvaluateQUICDetailed was hardcoded to return Deny as the default verdict, ignoring the engine's configured default. When default is "ask", QUIC traffic to unmatched destinations was silently dropped instead of triggering approval. Now uses e.Default so QUIC respects the same default as TCP.
…UIC, DNS, IMAP/SMTP
Bumps go-mitmproxy fork to include the header forwarding fix so that addon-modified headers (credential injection, custom headers) reach the upstream WS server during the handshake. Restores TestWebSocket_CredentialInjectionInUpgradeHeaders which now passes end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvaluateQUICDetailed was hardcoded to return Deny as the default verdict, ignoring the engine's configured default. When default is "ask", QUIC traffic to unmatched destinations was silently dropped instead of triggering approval.